linux-kernel - Re: [PATCH] iio: adc: Add support for DLN2 ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201706230633.AYOfQ9BM%fengguang.wu@intel.com>
Date:   Fri, 23 Jun 2017 06:30:19 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jack Andersen <jackoalan@...il.com>
Cc:     kbuild-all@...org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jack Andersen <jackoalan@...il.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Daniel Baluta <daniel.baluta@...el.com>,
        Octavian Purdila <octavian.purdila@...el.com>
Subject: Re: [PATCH] iio: adc: Add support for DLN2 ADC

Hi Jack,

[auto build test WARNING on iio/togreg]
[also build test WARNING on v4.12-rc6 next-20170622]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jack-Andersen/iio-adc-Add-support-for-DLN2-ADC/20170623-055246
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: blackfin-allyesconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

All warnings (new ones prefixed by >>):

   drivers/iio/adc/dln2-adc.c: In function 'dln2_adc_read':
>> drivers/iio/adc/dln2-adc.c:273:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     struct dln2_adc_port_chan port_chan = {
     ^~~~~~

vim +273 drivers/iio/adc/dln2-adc.c

   257	
   258		ret = dln2_transfer_tx(dln2->pdev, DLN2_ADC_CHANNEL_SET_CFG,
   259				       &set_cfg, sizeof(set_cfg));
   260		return ret;
   261	}
   262	
   263	static int dln2_adc_read(struct dln2_adc *dln2, unsigned int channel)
   264	{
   265		int ret;
   266	
   267		dln2->chans_requested |= (1 << channel);
   268		ret = dln2_adc_update_enabled_chans(dln2);
   269		if (ret < 0)
   270			return ret;
   271		dln2->port_enabled = 1;
   272	
 > 273		struct dln2_adc_port_chan port_chan = {
   274			.port = dln2->port,
   275			.chan = channel,
   276		};
   277		int ilen = sizeof(port_chan);
   278		__le16 value;
   279		int olen = sizeof(value);
   280	
   281		ret = dln2_transfer(dln2->pdev, DLN2_ADC_CHANNEL_GET_VAL,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (45008 bytes)