linux-kernel - Re: [PATCH] kdb: remove unnecessary variable assignment in kdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23b97f42-59cd-ffad-9446-0f6ce9595107@linaro.org>
Date:   Fri, 23 Jun 2017 09:06:13 +0100
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Jason Wessel <jason.wessel@...driver.com>
Cc:     kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kdb: remove unnecessary variable assignment in kdb_bc()

On 22/06/17 23:41, Gustavo A. R. Silva wrote:
> Value assigned to variable _bp_ at line 415 is the same as at line 434.
> This makes such variable assignment unnecessary.
> 
> Addresses-Coverity-ID: 1227025
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>

> ---
>   kernel/debug/kdb/kdb_bp.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c
> index 90ff129..039a329e 100644
> --- a/kernel/debug/kdb/kdb_bp.c
> +++ b/kernel/debug/kdb/kdb_bp.c
> @@ -412,7 +412,6 @@ static int kdb_bc(int argc, const char **argv)
>   		 * assume that the breakpoint number is desired.
>   		 */
>   		if (addr < KDB_MAXBPT) {
> -			bp = &kdb_breakpoints[addr];
>   			lowbp = highbp = addr;
>   			highbp++;
>   		} else {
>