linux-kernel - Re: [PATCH][V2] x86/microcode: make a couple of symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170623082707.lti7wqqsx273fnrv@pd.tnic>
Date:   Fri, 23 Jun 2017 10:27:07 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] x86/microcode: make a couple of symbols static

On Thu, Jun 22, 2017 at 10:57:36AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The helper function __load_ucode_amd and pointer intel_ucode_patch
> do not need to be in global scope, so make them static.
> 
> Cleans up sparse warnings:
> "symbol '__load_ucode_amd' was not declared. Should it be static?"
> "symbol 'intel_ucode_patch' was not declared. Should it be static?"
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  arch/x86/kernel/cpu/microcode/amd.c   | 2 +-
>  arch/x86/kernel/cpu/microcode/intel.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.