linux-kernel - Re: [PATCH] irqchip: irq-gic-v3-its-pci-msi: make of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d02d708-3942-12d5-dd6f-04a2a96db4d9@arm.com>
Date:   Fri, 23 Jun 2017 11:24:54 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, tglx@...utronix.de,
        jason@...edaemon.net
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: irq-gic-v3-its-pci-msi: make of_device_ids const

On 23/06/17 11:11, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/irqchip/irq-gic-v3-its-pci-msi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
> index aee1c60..44f80ec 100644
> --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c
> +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
> @@ -102,7 +102,7 @@ static int its_pci_msi_prepare(struct irq_domain *domain, struct device *dev,
>  	.chip	= &its_msi_irq_chip,
>  };
>  
> -static struct of_device_id its_device_id[] = {
> +static const struct of_device_id its_device_id[] = {
>  	{	.compatible	= "arm,gic-v3-its",	},
>  	{},
>  };
> 

I already sent the pull request to Thomas, so this one will have to
wait. In general, it'd be better if you sent these fixes as a series for
a given subsystem rather than one or two patches every other day.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...