linux-kernel - Re: [PATCH] bcache: release the allocated id, not its multiple of BCACHE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKhg4tJNzMEusd56MiDZO60aB5pfKWQVe-1We9sF2uzs8WEFyA@mail.gmail.com>
Date:   Fri, 23 Jun 2017 19:36:37 +0800
From:   Liang Chen <liangchen.linux@...il.com>
To:     Coly Li <i@...y.li>
Cc:     linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org,
        colyli@...e.de, bcache@...ux.ewheeler.net
Subject: Re: [PATCH] bcache: release the allocated id, not its multiple of BCACHE_MINORS

Hi Coly,
Thanks for letting me know.  Glad to see it's fixed.

Thanks,
Liang

On Fri, Jun 23, 2017 at 3:30 PM, Coly Li <i@...y.li> wrote:
> On 2017/6/23 下午3:15, Liang Chen wrote:
>> The id passed to ida_simple_remove has to be the one originally
>> allocated with ida_simple_get, not the one after multipling by
>> BCACHE_MINORS.
>>
>> Signed-off-by: Liang Chen <liangchen.linux@...il.com>
>> ---
>>  drivers/md/bcache/super.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
>> index e57353e..9f64477 100644
>> --- a/drivers/md/bcache/super.c
>> +++ b/drivers/md/bcache/super.c
>> @@ -734,7 +734,8 @@ static void bcache_device_free(struct bcache_device *d)
>>       if (d->disk && d->disk->queue)
>>               blk_cleanup_queue(d->disk->queue);
>>       if (d->disk) {
>> -             ida_simple_remove(&bcache_minor, d->disk->first_minor);
>> +             ida_simple_remove(&bcache_minor,
>> +                             d->disk->first_minor / BCACHE_MINORS);
>>               put_disk(d->disk);
>>       }
>>
>> @@ -784,7 +785,7 @@ static int bcache_device_init(struct bcache_device *d, unsigned block_size,
>>
>>       if (!(d->bio_split = bioset_create(4, offsetof(struct bbio, bio))) ||
>>           !(d->disk = alloc_disk(BCACHE_MINORS))) {
>> -             ida_simple_remove(&bcache_minor, minor);
>> +             ida_simple_remove(&bcache_minor, minor / BCACHE_MINORS);
>>               return -ENOMEM;
>>       }
>>
>>
>
> Hi Liang,
>
> Junhui fixes it already, the patch is submitted to Jens Axboe already.
> Maybe the patch will show up in next merge window.
>
>
> --
> Coly Li