linux-kernel - [PATCH] staging: wlan-ng: Fix sparse warning: incorrect type in assignment This patch fixes the following sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Jun 2017 04:21:54 +0200
From:   AbdAllah-MEZITI <abdallah.meziti.pro@...il.com>
To:     gregkh@...uxfoundation.org
Cc:     Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Juliana Rodrigues <juliana.orod@...il.com>,
        Andrea della Porta <sfaragnaus@...il.com>,
        Frans Klaver <fransklaver@...il.com>,
        Shiva Kerdel <shiva@...ev.nl>,
        sayli karnik <karniksayli1995@...il.com>,
        Rehas Sachdeva <aquannie@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH] staging: wlan-ng: Fix sparse warning: incorrect type in assignment This patch fixes the following sparse warning

drivers/staging/wlan-ng/prism2mgmt.c:188:25: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/prism2mgmt.c:188:25:    expected unsigned short [unsigned] [addressable] [usertype] tx_rate
drivers/staging/wlan-ng/prism2mgmt.c:188:25:    got restricted __le16 [usertype] <noident>
drivers/staging/wlan-ng/prism2mgmt.c:200:30: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/prism2mgmt.c:200:30:    expected unsigned short [unsigned] [addressable] [usertype] channel_list
drivers/staging/wlan-ng/prism2mgmt.c:200:30:    got restricted __le16 [usertype] <noident>
drivers/staging/wlan-ng/prism2mgmt.c:203:26: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/prism2mgmt.c:203:26:    expected unsigned short [unsigned] [addressable] [usertype] len
drivers/staging/wlan-ng/prism2mgmt.c:203:26:    got restricted __le16 [usertype] <noident>
drivers/staging/wlan-ng/prism2mgmt.c:232:28: warning: incorrect type in assignment (different base types)
drivers/staging/wlan-ng/prism2mgmt.c:232:28:    expected unsigned short [unsigned] [short] <noident>
drivers/staging/wlan-ng/prism2mgmt.c:232:28:    got restricted __le16 [usertype] <noident>

Signed-off-by: AbdAllah-MEZITI <abdallah.meziti.pro@...il.com>
---
 drivers/staging/wlan-ng/hfa384x.h    | 6 +++---
 drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 60110b4..1dc6ed8 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -358,7 +358,7 @@ struct hfa384x_bytestr {
 } __packed;
 
 struct hfa384x_bytestr32 {
-	u16 len;
+	__le16 len;
 	u8 data[32];
 } __packed;
 
@@ -399,8 +399,8 @@ struct hfa384x_caplevel {
 
 /*-- Configuration Record: HostScanRequest (data portion only) --*/
 struct hfa384x_host_scan_request_data {
-	u16 channel_list;
-	u16 tx_rate;
+	__le16 channel_list;
+	__le16 tx_rate;
 	struct hfa384x_bytestr32 ssid;
 } __packed;
 
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
index f4d6e48..c4aa9e7 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
+++ b/drivers/staging/wlan-ng/prism2mgmt.c
@@ -213,7 +213,7 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)
 		goto exit;
 	}
 	if (word == HFA384x_PORTSTATUS_DISABLED) {
-		u16 wordbuf[17];
+		__le16 wordbuf[17];
 
 		result = hfa384x_drvr_setconfig16(hw,
 					HFA384x_RID_CNFROAMINGMODE,
-- 
2.7.4