linux-kernel - Re: [PATCH v2 2/2] smartpqi: limit transfer length to 1MB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170623130141.GE13014@linux-x5ow.site>
Date:   Fri, 23 Jun 2017 15:01:41 +0200
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Yadan Fan <ydfan@...e.com>
Cc:     don.brace@...rosemi.com, martin.petersen@...cle.com,
        jejb@...ux.vnet.ibm.com, esc.storagedev@...rosemi.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] smartpqi: limit transfer length to 1MB

On Fri, Jun 23, 2017 at 05:40:06PM +0800, Yadan Fan wrote:
> The smartpqi firmware will bypass the cache for any request larger
> than 1MB, so we should cap the request size to avoid any
> performance degradation in kernels later than v4.3
> 
> This degradation is caused from d2be537c3ba3568acd79cd178327b842e60d035e,
> which changed max_sectors_kb to 1280k, but the hardware is able to
> work fine with it, so the true fix should be from smartpqi driver.
> 
> Signed-off-by: Yadan Fan <ydfan@...e.com>
> ---

Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850