linux-kernel - Re: [PATCH v2] vsprintf: Add %p extension "%pOF" for device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Jun 2017 09:08:55 -0500
From:   Rob Herring <robh@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Grant Likely <glikely@...retlab.ca>,
        Frank Rowand <frowand.list@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Joe Perches <joe@...ches.com>,
        Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] vsprintf: Add %p extension "%pOF" for device tree

On Thu, Jun 22, 2017 at 5:44 PM, Randy Dunlap <rdunlap@...radead.org> wrote:
> On 06/22/2017 01:44 PM, Rob Herring wrote:
>> From: Pantelis Antoniou <pantelis.antoniou@...sulko.com>
>>
>> 90% of the usage of device node's full_name is printing it out in a
>> kernel message. However, storing the full path for every node is
>> wasteful and redundant. With a custom format specifier, we can generate
>> the full path at run-time and eventually remove the full path from every
>> node.
>>
>> For instance typical use is:
>>       pr_info("Frobbing node %s\n", node->full_name);
>>
>> Which can be written now as:
>>       pr_info("Frobbing node %pOF\n", node);
>
>
> isn't OF for flags -- and Of for full name?
> Typo or a change in the last 2 years?

It changed in the discussion 2 years ago. The intent is:

%pO - kobj
%pOF - device_node, defaulting to full name

There's no support of base kobj's, but I guess I should make that
intent clear in the documentation.

Rob