linux-kernel - Re: [PATCH v4 1/4] perf/core: addressing 4x slowdown during per-process profiling of STREAM benchmark on Intel Xeon Phi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170623145826.GA26953@leverpostej>
Date:   Fri, 23 Jun 2017 15:58:40 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Alexey Budankov <alexey.budankov@...ux.intel.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kan Liang <kan.liang@...el.com>,
        Dmitri Prokhorov <Dmitry.Prohorov@...el.com>,
        Valery Cherepennikov <valery.cherepennikov@...el.com>,
        David Carrillo-Cisneros <davidcc@...gle.com>,
        Stephane Eranian <eranian@...gle.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/4] perf/core: addressing 4x slowdown during
 per-process profiling of STREAM benchmark on Intel Xeon Phi

Hi,

As a heads-up, it looks like something is mangling these patches. I see
that the @@ lines in patches are line-wrapped, which from git am's PoV
means the patches are corrupt.

On Wed, Jun 21, 2017 at 06:39:24PM +0300, Alexey Budankov wrote:
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index bc63f8d..fc37e30 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -1458,8 +1458,12 @@ static enum event_type_t
> get_event_type(struct perf_event *event)

e.g. the last two lines above should be one line.

> @@ -1467,6 +1471,223 @@ ctx_group_list(struct perf_event *event,
> struct perf_event_context *ctx)

Likewise.

> @@ -1485,12 +1706,8 @@ list_add_event(struct perf_event *event,
> struct perf_event_context *ctx)

Likewise.

> @@ -1681,7 +1898,7 @@ list_del_event(struct perf_event *event,
> struct perf_event_context *ctx)

Likewise.

... and so on throughout the patch.

I'm only seeing this on patches from you, and I see this both from my
arm.com account and a gmail account subscribed to LKML, whether I export
this from mutt or from the gmail web interface.

Can you check if your MTA is doing something here?

It's possible to fix this up manually, but it's rather tedious.

Thanks,
Mark.