linux-kernel - Re: [PATCH] PATCH v3 Convert multiple netdev_info messages to netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170623.133352.2059206023839972118.davem@davemloft.net>
Date:   Fri, 23 Jun 2017 13:33:52 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     michael.j.dilmore@...il.com
Cc:     j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        joe@...ches.com
Subject: Re: [PATCH] PATCH v3 Convert multiple netdev_info messages to
 netdev_dbg

From: Michael J Dilmore <michael.j.dilmore@...il.com>
Date: Wed, 21 Jun 2017 03:08:54 +0100

> The bond_options.c file contains multiple netdev_info messages that
> clutter kernel output. This patches replaces these with netdev_dbg messages
> and adds a netdev_dbg for packets for slave.
> 
> Signed-off-by: Michael J Dilmore <michael.j.dilmore@...il.com>
> Suggested-by: Joe Perches <joe@...ches.com>

This falls under the category of "very low quality patch submission"
I'm afraid.

First of all your Subject lines need to be done more properly.

Puting "PATCH" twice in there is pointless, just once inside of the
brackets is enough.  The "v3" belongs inside of the brackets too.

Seriously, just look at how other developer format their Subject lines
on this mailing list, and you are less likely to go wrong.  Doing thing
your own unique way is asking for trouble.

But more importantly, your commit log message says you are converting
netdev_info calls into netdev_dbg ones, but that is not at all what
this patch does.

>  		netdev_dbg(bond->dev, "%s mode is incompatible with arp monitoring, start mii monitoring\n",
> -			    newval->string);
> +			   newval->string);

You're simply adjusting indentation of the code.

There are no "conversions" going on here at all.