linux-kernel - Re: [PATCH RESEND 09/13] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170623175456.GA131781@decatoncale.mtv.corp.google.com>
Date:   Fri, 23 Jun 2017 10:54:56 -0700
From:   Benson Leung <bleung@...gle.com>
To:     Thierry Escande <thierry.escande@...labora.com>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        olof@...om.net, bleung@...omium.org, linux-kernel@...r.kernel.org,
        lee.jones@...aro.org, Gwendal Grignou <gwendal@...omium.org>
Subject: Re: [PATCH RESEND 09/13] platform/chrome: cros_ec_lpc: Add MKBP
 events support over ACPI

Hi Thierry,

On Fri, Jun 23, 2017 at 09:35:06AM +0200, Thierry Escande wrote:
> Hi Benson,
> 
> On 22/06/2017 21:35, Benson Leung wrote:
> 
> <snip>
> 
> >>+	adev = ACPI_COMPANION(dev);
> >>+	if (adev) {
> >>+		status = acpi_install_notify_handler(adev->handle,
> >>+						     ACPI_ALL_NOTIFY,
> >
> >Is there a reason you're using ACPI_ALL_NOTIFY here instead of
> >ACPI_SYSTEM_NOTIFY that is done in the CHROMIUM version of this?
> >
> In the original patch
> (https://chromium-review.googlesource.com/c/358155/) ACPI_ALL_NOTIFY
> is passed to acpi_install_notify_handler() and ACPI_SYSTEM_NOTIFY to
> acpi_remove_notify_handler. I changed it for remove_notify call to
> unsure all handler references were removed.
> 

Oh, I see. Looks good. I'll go ahead and make the same change in the
chromeos-4.4 kernel too.

Signed-off-by: Benson Leung <bleung@...omium.org>

Applied.

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)