linux-kernel - Re: [PATCH v2] fs: warn in case userspace lied about modprobe return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170623182732.GQ21846@wotan.suse.de>
Date:   Fri, 23 Jun 2017 20:27:32 +0200
From:   "Luis R. Rodriguez" <mcgrof@...nel.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, rusty@...tcorp.com.au,
        jeyu@...hat.com, mcgrof@...nel.org
Subject: Re: [PATCH v2] fs: warn in case userspace lied about modprobe return

On Tue, Jun 20, 2017 at 10:57:46PM +0200, Luis R. Rodriguez wrote:
> On Thu, Jun 01, 2017 at 11:08:01AM -0700, Luis R. Rodriguez wrote:
> > kmod <= v19 was broken -- it could return 0 to modprobe calls,
> > incorrectly assuming that a kernel module was built-in, whereas in
> > reality the module was just forming in the kernel. The reason for this
> > is an incorrect userspace heuristics. A userspace kmod fix is available
> > for it [0], however should userspace break again we could go on with
> > an failed get_fs_type() which is hard to debug as the request_module()
> > is detected as returning 0. The first suspect would be that there is
> > something worth with the kernel's module loader and obviously in this
> > case that is not the issue.
> > 
> > Since these issues are painful to debug complain when we know userspace
> > has outright lied to us.
> > 
> > [0] http://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/libkmod/libkmod-module.c?id=fd44a98ae2eb5eb32161088954ab21e58e19dfc4
> > 
> > Suggested-by: Rusty Russell <rusty@...tcorp.com.au>
> > Cc: Jessica Yu <jeyu@...hat.com>
> > Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>
> 
> *poke* Al?

Will bounce to the default tree maintainer, Andrew :)

  Luis