linux-kernel - Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170623184305.xqqhjgrbdmgk6lsr@ninjato>
Date:   Fri, 23 Jun 2017 20:43:05 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Brendan Higgins <brendanhiggins@...gle.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com,
        gregkh@...uxfoundation.org, davem@...emloft.net,
        mchehab@...nel.org, joel@....id.au, martin.petersen@...cle.com,
        benh@...nel.crashing.org, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        openbmc@...ts.ozlabs.org
Subject: Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C

On Tue, Jun 20, 2017 at 02:15:15PM -0700, Brendan Higgins wrote:
> Added initial master support for Aspeed I2C controller. Supports
> fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed.
> 
> Signed-off-by: Brendan Higgins <brendanhiggins@...gle.com>

Applied to for-next, thanks for all the hard work!

One question however which can be solved incrementally if needed:

> +	if (command & ASPEED_I2CD_SDA_LINE_STS) {
> +		/* Bus is idle: no recovery needed. */
> +		if (command & ASPEED_I2CD_SCL_LINE_STS)
> +			goto out;
> +		dev_dbg(bus->dev, "SCL hung (state %x), attempting recovery\n",
> +			command);
> +
> +		reinit_completion(&bus->cmd_complete);
> +		writel(ASPEED_I2CD_M_STOP_CMD, bus->base + ASPEED_I2C_CMD_REG);

If SCL is stuck low, how do you want to send a STOP?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)