linux-kernel - Re: [PATCH 2/5] Docs: Remove redundant geometry package inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170623133951.49bf28f8@lwn.net>
Date:   Fri, 23 Jun 2017 13:39:51 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Mauro Carvalho Chehab <mchehab@...pensource.com>
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jim Davis <jim.epost@...il.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>
Subject: Re: [PATCH 2/5] Docs: Remove redundant geometry package inclusion

On Mon, 19 Jun 2017 07:49:06 -0300
Mauro Carvalho Chehab <mchehab@...pensource.com> wrote:

> There's a catch, though: as sphinxsetup hmargin/vmargin was added
> only on Sphinx version 1.5.3, the enclosed patch won't adjust the
> margins for versions 1.5.0 to 1.5.2. While I didn't test, I bet it
> will just ignore the keys, showing some warning.

And people routinely accuse *me* of being overly optimistic...

> ! Package keyval Error: hmargin undefined.
> 
> See the keyval package documentation for explanation.
> Type  H <return>  for immediate help.
>  ...                                              
>                                                   
> l.19 \sphinxsetup{hmargin=0.5in, vmargin=0.5in}
>                                                
> ? 

So it kills the build on 1.5.2.

I've made a tweak to special-case early 1.5.x.  

> Fixes: 85c21e5c3ee74fb75d690c57f7066bae7e2dca55
> Sighed-off-by: Mauro Carvalho Chehab <mchehab@...pensource.com>

Sighed-off-by indeed, I agree.  It's a good thing there's a lot of beer in
the fridge...

jon