linux-kernel - Re: [PATCH] FIXUP: CHROMIUM: fix transposed param settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170623202313.GA122611@google.com>
Date:   Fri, 23 Jun 2017 13:23:15 -0700
From:   Brian Norris <briannorris@...omium.org>
To:     Nick Vaccaro <nvaccaro@...gle.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] FIXUP: CHROMIUM: fix transposed param settings

Hi Nick,

When sending patches to kernel mailing lists, we don't use prefixes like
"CHROMIUM" -- those only apply to Chrome OS kernel trees, to indicate
patches that should be specific to the Chromium (OS) project and not
necessarily upstream Linux.

Here, you want to follow the patterns used by the subsystem. This is
sort of covered in the Documentation/process/ directory:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

Or you might look at 'git log drivers/pwm/ here.

i.e., this might have a subject:

[PATCH] pwm: cros-ec: fix transposed param settings

On Thu, Jun 22, 2017 at 10:54:39AM -0700, Nick Vaccaro wrote:
> The __cros_ec_pwm_get_duty() routine was transposing the insize and
> outsize fields when calling cros_ec_cmd_xfer_status().
> 
> The original code worked without error due to size of the two particular
> parameter blocks passed to cros_ec_cmd_xfer_status(), so this change is
> not fixing an actual runtime problem, just correcting the calling usage.
> 
> Signed-off-by: Nick Vaccaro <nvaccaro@...omium.org>
> ---

Patch looks good:

Reviewed-by: Brian Norris <briannorris@...omium.org>

>  drivers/pwm/pwm-cros-ec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c
> index 2e4ab20cfb83..de5b7c9860b6 100644
> --- a/drivers/pwm/pwm-cros-ec.c
> +++ b/drivers/pwm/pwm-cros-ec.c
> @@ -75,8 +75,8 @@ static int __cros_ec_pwm_get_duty(struct cros_ec_device *ec, u8 index,
>  
>  	msg->version = 0;
>  	msg->command = EC_CMD_PWM_GET_DUTY;
> -	msg->insize = sizeof(*params);
> -	msg->outsize = sizeof(*resp);
> +	msg->insize = sizeof(*resp);
> +	msg->outsize = sizeof(*params);
>  
>  	params->pwm_type = EC_PWM_TYPE_GENERIC;
>  	params->index = index;