linux-kernel - Re: [PATCH] Staging: rtl8712 : osdep_intf.h: fix macro coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170623172422.GB19626@kroah.com>
Date:   Fri, 23 Jun 2017 19:24:22 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jaya Durga <rjdurga@...il.com>
Cc:     Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
        binoy.jayan@...aro.org, arnd@...db.de, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, Jaya Durga <jayad@...c.in>
Subject: Re: [PATCH] Staging: rtl8712 : osdep_intf.h: fix macro coding style
 issue

On Thu, Jun 22, 2017 at 12:10:04PM +0530, Jaya Durga wrote:
> From: Jaya Durga <jayad@...c.in>
> 
> Fix checkpatch.pl warning of the form "CHECK" Macro argument 'x'
> may be better as '(x)' to avoid precedence issues.
> 
> Signed-off-by: Jaya Durga <jayad@...c.in>
> ---
>  drivers/staging/rtl8712/osdep_intf.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/osdep_intf.h b/drivers/staging/rtl8712/osdep_intf.h
> index 5d37e1f..1985423 100644
> --- a/drivers/staging/rtl8712/osdep_intf.h
> +++ b/drivers/staging/rtl8712/osdep_intf.h
> @@ -29,7 +29,7 @@
>  #include "osdep_service.h"
>  #include "drv_types.h"
> 
> -#define RND4(x)	(((x >> 2) + (((x & 3) == 0) ?  0 : 1)) << 2)
> +#define RND4(x)	((((x) >> 2) + ((((x) & 3) == 0) ?  0 : 1)) << 2)

Why not move this to use the in-kernel macros instead?

thanks,

greg k-h