linux-kernel - Re: [PATCH] staging: lustre: lnet: selftest: Change the type of variable to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170623161631.GC20104@kroah.com>
Date:   Sat, 24 Jun 2017 00:16:31 +0800
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     simran singhal <singhalsimran0@...il.com>
Cc:     Oleg Drokin <oleg.drokin@...el.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org,
        Andreas Dilger <andreas.dilger@...el.com>,
        lustre-devel@...ts.lustre.org
Subject: Re: [PATCH] staging: lustre: lnet: selftest: Change the type of
 variable to bool

On Tue, Jun 20, 2017 at 02:36:37PM +0530, simran singhal wrote:
> This patch changes the type of variable done from int to boolean. As it
> is been used as a boolean in the function sfw_test_rpc_done(). It also
> makes the code more readable and bool data type also requires less
> memory in comparison to int data type.

Are you sure it takes less memory?  What is the difference before and
after your patch?  Don't make claims without having a way to back them
up :)

thanks,

greg k-h