lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 24 Jun 2017 00:34:41 +0800
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Derek Robson <robsonde@...il.com>
Cc:     arnd@...db.de, binoy.jayan@...aro.org, singhalsimran0@...il.com,
        karniksayli1995@...il.com, yamada.masahiro@...ionext.com,
        salah.triki@....org, colin.king@...onical.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] staging: rtl8192u: style fix

On Sat, Jun 17, 2017 at 03:26:32PM +1200, Derek Robson wrote:
> Fixed checkpatch.pl warnings of "function definition argument FOO should
> also have an identifier name"
> Found using checkpatch
> 
> Signed-off-by: Derek Robson <robsonde@...il.com>
> 
> V1 had vauge subjet

v2 does as well :(

Also this V1 line needs to go below the --- line, otherwise it ends up
in the changelog text.  Please fix up and make a v3.

thanks,

greg k-h

Powered by blists - more mailing lists