linux-kernel - Re: [PATCH] staging: octeon-usb: coding style fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170623160446.GA19861@kroah.com>
Date:   Sat, 24 Jun 2017 00:04:46 +0800
From:   Greg KH <gregkh@...uxfoundation.org>
To:     bincy_k_philip@...oo.co.in
Cc:     aquannie@...il.com, anton.bondarenko.sama@...il.com,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: octeon-usb: coding style fix

On Thu, Jun 15, 2017 at 10:28:47AM +0530, bincy_k_philip@...oo.co.in wrote:
> From: bincy k philip <bincy_k_philip@...oo.co.in>

Please use Capital Letters for your name.

> 
> trivial fix for extra space error
> 
> Signed-off-by: bincy k philip <bincy_k_philip@...oo.co.in>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 068aece..c7ec71a 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -146,7 +146,7 @@ enum cvmx_usb_status {
>   *			status call.
>   */
>  struct cvmx_usb_port_status {
> -	u32 reserved			: 25;
> +	u32 reserved:25;

What?  That's not a correct "fix" at all, sorry.

greg k-h