linux-kernel - Re: [PATCH] EDAC, pnd2_edac: make function sbi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170623204759.2op7zhjtfgyqd7db@intel.com>
Date:   Fri, 23 Jun 2017 13:48:00 -0700
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Colin King <colin.king@...onical.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-edac@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static

On Fri, Jun 23, 2017 at 10:58:24AM +0200, Borislav Petkov wrote:
> On Fri, Jun 23, 2017 at 09:48:55AM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> > -int sbi_send(int port, int off, int op, u32 *data)
> > +static int sbi_send(int port, int off, int op, u32 *data)
> 
> Tony, were those supposed to be used somewhere outside of the driver,
> i.e., that CONFIG_X86_INTEL_SBI_APL thing?

No.  This function is internal and can be static.

The CONFIG_X86_INTEL_SBI_APL thing is about sbi_apl_commit()
while is still waiting for a sideband driver that defines it
to be pushed upstream.

-Tony