linux-kernel - Re: [PATCH] pci: Add and use PCI_GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170623220104.GE31455@jhogan-linux.le.imgtec.org>
Date:   Fri, 23 Jun 2017 23:01:04 +0100
From:   James Hogan <james.hogan@...tec.com>
To:     Palmer Dabbelt <palmer@...belt.com>
CC:     <rth@...ddle.net>, <ink@...assic.park.msu.ru>,
        <mattst88@...il.com>, <vgupta@...opsys.com>,
        <linux@...linux.org.uk>, <catalin.marinas@....com>,
        <will.deacon@....com>, <geert@...ux-m68k.org>,
        <ralf@...ux-mips.org>, <ysato@...rs.sourceforge.jp>,
        <dalias@...c.org>, <davem@...emloft.net>, <cmetcalf@...lanox.com>,
        <gxt@...c.pku.edu.cn>, <bhelgaas@...gle.com>,
        <viro@...iv.linux.org.uk>, <akpm@...ux-foundation.org>,
        <linux-alpha@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-snps-arc@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-m68k@...ts.linux-m68k.org>, <linux-mips@...ux-mips.org>,
        <linux-sh@...r.kernel.org>, <sparclinux@...r.kernel.org>,
        <linux-pci@...r.kernel.org>, <hch@...radead.org>
Subject: Re: [PATCH] pci:  Add and use PCI_GENERIC_SETUP Kconfig entry

On Fri, Jun 23, 2017 at 02:45:38PM -0700, Palmer Dabbelt wrote:
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 4c1a35f15838..86872246951c 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -96,6 +96,7 @@ config ARM
>  	select PERF_USE_VMALLOC
>  	select RTC_LIB
>  	select SYS_SUPPORTS_APM_EMULATION
> +	select PCI_GENERIC_SETUP
>  	# Above selects are sorted alphabetically; please add new ones
>  	# according to that.  Thanks.

This comment seems to suggest PCI_GENERIC_SETUP should be added a few
lines up to preserve the alphabetical sorting.

> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index b2024db225a9..6c684d8c8816 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -115,6 +115,7 @@ config ARM64
>  	select SPARSE_IRQ
>  	select SYSCTL_EXCEPTION_TRACE
>  	select THREAD_INFO_IN_TASK
> +	select PCI_GENERIC_SETUP

Here too.

> diff --git a/arch/tile/Kconfig b/arch/tile/Kconfig
> index 4583c0320059..6679af85a882 100644
> --- a/arch/tile/Kconfig
> +++ b/arch/tile/Kconfig
> @@ -33,6 +33,7 @@ config TILE
>  	select USER_STACKTRACE_SUPPORT
>  	select USE_PMC if PERF_EVENTS
>  	select VIRT_TO_BUS
> +	select PCI_GENERIC_SETUP

and here

Otherwise
Reviewed-by: James Hogan <james.hogan@...tec.com>

Cheers
James

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)