linux-kernel - Re: [PATCH] mm: larger stack guard gap, between vmas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.11.1706222119230.23215@eggly.anvils>
Date:   Thu, 22 Jun 2017 21:35:07 -0700 (PDT)
From:   Hugh Dickins <hughd@...gle.com>
To:     Ben Hutchings <ben@...adent.org.uk>
cc:     Hugh Dickins <hughd@...gle.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Michal Hocko <mhocko@...nel.org>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Rik van Riel <riel@...hat.com>,
        Larry Woodman <lwoodman@...hat.com>,
        "Kirill A. Shutemov" <kirill@...temov.name>,
        Tony Luck <tony.luck@...el.com>,
        "James E.J. Bottomley" <jejb@...isc-linux.org>,
        Helge Diller <deller@....de>,
        James Hogan <james.hogan@...tec.com>,
        Laura Abbott <labbott@...hat.com>, Willy Tarreau <w@....eu>,
        Greg KH <greg@...ah.com>, stable <stable@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, 22 Jun 2017, Ben Hutchings wrote:

> Here's my attempt at a backport to 3.2.  This is only tested on
> x86_64 and I think I should introduce local variables for
> vma_start_gap() in a few places.  I had to cherry-pick commit
> 09884964335e "mm: do not grow the stack vma just because of an overrun
> on preceding vma" before this one (which was a clean cherry-pick).

Both your speed and your stamina are much better than mine; and your
patch belies your Sturgeon's law signature.  I haven't got beyond the
architectures yet in my parallel attempt, and you do appear to be
doing everything right (but a local variable often welcome, yes).

I'm giving up for the night, will contine tomorrow.
The only discrepancy I notice so far is that I have
arch/alpha/kernel/osf_sys.c
arch/ia64/mm/hugetlbpage.c
arch/sparc/kernel/sys_sparc_32.c
in my list of changed files, but they're not in yours.

Hugh