linux-kernel - Re: [PATCH net-next] net: add netlink_ext_ack support to rtnl_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bfb7a80-a440-f960-1f35-a70542106cfb@gmail.com>
Date:   Sat, 24 Jun 2017 20:50:24 -0600
From:   David Ahern <dsahern@...il.com>
To:     Matthias Schiffer <mschiffer@...verse-factory.net>,
        dledford@...hat.com, sean.hefty@...el.com,
        hal.rosenstock@...il.com, j.vosburgh@...il.com, vfalico@...il.com,
        andy@...yhouse.net, dmitry.tarnyagin@...kless.no,
        wg@...ndegger.com, mkl@...gutronix.de, pablo@...filter.org,
        laforge@...monks.org, paulus@...ba.org, jiri@...nulli.us,
        dsa@...ulusnetworks.com, shm@...ulusnetworks.com,
        davem@...emloft.net, stephen@...workplumber.org,
        arvid.brodin@...en.se, alex.aring@...il.com,
        stefan@....samsung.com, kuznet@....inr.ac.ru, jmorris@...ei.org,
        yoshfuji@...ux-ipv6.org, kaber@...sh.net,
        steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        johannes@...solutions.net
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, linux-can@...r.kernel.org,
        osmocom-net-gprs@...ts.osmocom.org, linux-ppp@...r.kernel.org,
        linux-wpan@...r.kernel.org
Subject: Re: [PATCH net-next] net: add netlink_ext_ack support to
 rtnl_link_ops

On 6/24/17 5:35 AM, Matthias Schiffer wrote:
> The following functions are extended with a netlink_ext_ack argument to
> allow extended error reporting:
> 
> * validate
> * newlink
> * changelink
> * slave_validate
> * slave_changelink

I would prefer separate patches for validate, slave_validate, newlink,
changelink, and slave_changelink. I do not believe there is a reason to
lump them into 1 giant patch.