linux-kernel - Re: [PATCH] staging: sm750fb: always take the lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH6sp9NFxsvkGsLAD=B_nTOKZh9u89HuESqNywyQAqFxqtMKvA@mail.gmail.com>
Date:   Mon, 26 Jun 2017 08:33:37 +0200
From:   Frans Klaver <fransklaver@...il.com>
To:     AbdAllah-MEZITI <abdallah.meziti.pro@...il.com>
Cc:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Teddy Wang <teddy.wang@...iconmotion.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: sm750fb: always take the lock

There's no version number. Which one is the correct one?

On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI
<abdallah.meziti.pro@...il.com> wrote:
> This patch
> - will always take the lock
> - fix the sparse warning:
> drivers/staging/sm750fb/sm750.c:159:13: warning: context imbalance in 'lynxfb_ops_fillrect' - different lock contexts for basic block
> drivers/staging/sm750fb/sm750.c:231:9: warning: context imbalance in 'lynxfb_ops_copyarea' - different lock contexts for basic block
> drivers/staging/sm750fb/sm750.c:235:13: warning: context imbalance in 'lynxfb_ops_imageblit' - different lock contexts for basic block
>
> Signed-off-by: AbdAllah MEZITI <abdallah.meziti.pro@...il.com>
> ---
>  drivers/staging/sm750fb/sm750.c | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 386d4ad..4a22190 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -186,16 +186,14 @@ static void lynxfb_ops_fillrect(struct fb_info *info,
>          * If not use spin_lock,system will die if user load driver
>          * and immediately unload driver frequently (dual)
>          */
> -       if (sm750_dev->fb_count > 1)
> -               spin_lock(&sm750_dev->slock);
> +       spin_lock(&sm750_dev->slock);
>
>         sm750_dev->accel.de_fillrect(&sm750_dev->accel,
>                                      base, pitch, Bpp,
>                                      region->dx, region->dy,
>                                      region->width, region->height,
>                                      color, rop);
> -       if (sm750_dev->fb_count > 1)
> -               spin_unlock(&sm750_dev->slock);
> +       spin_unlock(&sm750_dev->slock);
>  }
>
>  static void lynxfb_ops_copyarea(struct fb_info *info,
> @@ -220,16 +218,14 @@ static void lynxfb_ops_copyarea(struct fb_info *info,
>          * If not use spin_lock, system will die if user load driver
>          * and immediately unload driver frequently (dual)
>          */
> -       if (sm750_dev->fb_count > 1)
> -               spin_lock(&sm750_dev->slock);
> +       spin_lock(&sm750_dev->slock);
>
>         sm750_dev->accel.de_copyarea(&sm750_dev->accel,
>                                      base, pitch, region->sx, region->sy,
>                                      base, pitch, Bpp, region->dx, region->dy,
>                                      region->width, region->height,
>                                      HW_ROP2_COPY);
> -       if (sm750_dev->fb_count > 1)
> -               spin_unlock(&sm750_dev->slock);
> +       spin_unlock(&sm750_dev->slock);
>  }
>
>  static void lynxfb_ops_imageblit(struct fb_info *info,
> @@ -269,8 +265,7 @@ static void lynxfb_ops_imageblit(struct fb_info *info,
>          * If not use spin_lock, system will die if user load driver
>          * and immediately unload driver frequently (dual)
>          */
> -       if (sm750_dev->fb_count > 1)
> -               spin_lock(&sm750_dev->slock);
> +       spin_lock(&sm750_dev->slock);
>
>         sm750_dev->accel.de_imageblit(&sm750_dev->accel,
>                                       image->data, image->width >> 3, 0,
> @@ -278,8 +273,7 @@ static void lynxfb_ops_imageblit(struct fb_info *info,
>                                       image->dx, image->dy,
>                                       image->width, image->height,
>                                       fgcol, bgcol, HW_ROP2_COPY);
> -       if (sm750_dev->fb_count > 1)
> -               spin_unlock(&sm750_dev->slock);
> +       spin_unlock(&sm750_dev->slock);
>  }
>
>  static int lynxfb_ops_pan_display(struct fb_var_screeninfo *var,
> --
> 2.7.4
>