linux-kernel - Re: [PATCH] scsi: qedi: Remove comparison of u16 idx with zero.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D576B27D.3B0C5%manish.rangankar@cavium.com>
Date:   Mon, 26 Jun 2017 07:17:19 +0000
From:   "Rangankar, Manish" <Manish.Rangankar@...ium.com>
To:     Christos Gkekas <chris.gekas@...il.com>,
        Dept-Eng QLogic Storage Upstream 
        <QLogic-Storage-Upstream@...ium.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: qedi: Remove comparison of u16 idx with zero.



On 24/06/17 9:54 PM, "Christos Gkekas" <chris.gekas@...il.com> wrote:

>Variable idx is defined as u16 thus statement (idx < 0) is
>always false and should be removed.
>
>Signed-off-by: Christos Gkekas <chris.gekas@...il.com>
>---
> drivers/scsi/qedi/qedi_fw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c
>index e937490..19254bd 100644
>--- a/drivers/scsi/qedi/qedi_fw.c
>+++ b/drivers/scsi/qedi/qedi_fw.c
>@@ -333,7 +333,7 @@ static void qedi_get_rq_bdq_buf(struct qedi_ctx *qedi,
> 
> 	/* Obtain buffer address from rqe_opaque */
> 	idx = cqe->rqe_opaque.lo;
>-	if ((idx < 0) || (idx > (QEDI_BDQ_NUM - 1))) {
>+	if (idx > (QEDI_BDQ_NUM - 1)) {
> 		QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_CONN,
> 			  "wrong idx %d returned by FW, dropping the unsolicited pkt\n",
> 			  idx);
>@@ -370,7 +370,7 @@ static void qedi_put_rq_bdq_buf(struct qedi_ctx *qedi,
> 
> 	/* Obtain buffer address from rqe_opaque */
> 	idx = cqe->rqe_opaque.lo;
>-	if ((idx < 0) || (idx > (QEDI_BDQ_NUM - 1))) {
>+	if (idx > (QEDI_BDQ_NUM - 1)) {
> 		QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_CONN,
> 			  "wrong idx %d returned by FW, dropping the unsolicited pkt\n",
> 			  idx);
>-- 
>2.7.4

Acked-by: Manish Rangankar <Manish.Rangankar@...ium.com>