linux-kernel - Re: [PATCH v3 9/9] vfio: Add AMBA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43af635b-d9a0-888a-3ea5-2618a0c3d679@redhat.com>
Date:   Mon, 26 Jun 2017 09:30:28 +0200
From:   Auger Eric <eric.auger@...hat.com>
To:     Alex Williamson <alex.williamson@...hat.com>, kvm@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, linux@...linux.org.uk
Subject: Re: [PATCH v3 9/9] vfio: Add AMBA driver_override support

Hi Alex,

On 20/06/2017 17:48, Alex Williamson wrote:
> AMBA also supports driver_override, but amba_bustype was not exported
> to be able to identify an amba device.
> 
> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>
Reviewed-by: Eric Auger <eric.auger@...hat.com>

Eric
> ---
>  drivers/vfio/vfio.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
> index 20e57fecf652..36f0fcfded0b 100644
> --- a/drivers/vfio/vfio.c
> +++ b/drivers/vfio/vfio.c
> @@ -36,6 +36,7 @@
>  #include <linux/uuid.h>
>  #include <linux/vfio.h>
>  #include <linux/wait.h>
> +#include <linux/amba/bus.h>
>  
>  #define DRIVER_VERSION	"0.3"
>  #define DRIVER_AUTHOR	"Alex Williamson <alex.williamson@...hat.com>"
> @@ -743,6 +744,11 @@ static char **vfio_find_driver_override(struct device *dev)
>  	} else if (dev->bus == &platform_bus_type) {
>  		struct platform_device *pdev = to_platform_device(dev);
>  		return &pdev->driver_override;
> +#ifdef CONFIG_ARM_AMBA
> +	} else if (dev->bus == &amba_bustype) {
> +		struct amba_device *adev = to_amba_device(dev);
> +		return &adev->driver_override;
> +#endif
>  	}
>  
>  	return NULL;
>