linux-kernel - Re: [PATCH] staging: sm750fb: always take the lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH6sp9N621aYHde3Gfg=fxM8dCGzDYftP1_8EGQuwhJBj0kggg@mail.gmail.com>
Date:   Mon, 26 Jun 2017 11:16:42 +0200
From:   Frans Klaver <fransklaver@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     AbdAllah-MEZITI <abdallah.meziti.pro@...il.com>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Teddy Wang <teddy.wang@...iconmotion.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
        driverdevel <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: sm750fb: always take the lock

On Mon, Jun 26, 2017 at 11:11 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI
> <abdallah.meziti.pro@...il.com> wrote:
>> This patch
>> - will always take the lock
>
> Why?
>
> "The current code only takes the lock if multiple instances are in use.
>  This is error-prone, and confuses static analyzers.
>  As taking the lock in case of a single instance is harmful and cheap,
>  change the code to always take the lock."

I would argue that it's not harmful, lest people get confused about
it. And I agree that this explanation is much more useful than just
mentioning the warnings that you saw.

Thanks,
Frans