linux-kernel - Re: [PATCH v5 1/2] media: i2c: adv748x: add adv748x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Jun 2017 12:06:15 +0100
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     Rob Herring <robh@...nel.org>, Kieran Bingham <kbingham@...nel.org>
Cc:     laurent.pinchart@...asonboard.com, niklas.soderlund@...natech.se,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Kieran Bingham <kieran.bingham@...asonboard.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S. Miller" <davem@...emloft.net>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Pavel Machek <pavel@....cz>,
        Steve Longerbeam <slongerbeam@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Ramiro Oliveira <Ramiro.Oliveira@...opsys.com>,
        Arnd Bergmann <arnd@...db.de>,
        Todor Tomov <todor.tomov@...aro.org>,
        "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" 
        <linux-media@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 1/2] media: i2c: adv748x: add adv748x driver

Thanks Rob,

Comments addressed, and a new version 6 to be posted soon.

On 22/06/17 22:34, Rob Herring wrote:
> On Wed, Jun 14, 2017 at 08:58:12PM +0100, Kieran Bingham wrote:
>> From: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
>>
>> Provide support for the ADV7481 and ADV7482.
>>
>> The driver is modelled with 4 subdevices to allow simultaneous streaming
>> from the AFE (Analog front end) and HDMI inputs though two CSI TX
>> entities.
>>
>> The HDMI entity is linked to the TXA CSI bus, whilst the AFE is linked
>> to the TXB CSI bus.
>>
>> The driver is based on a prototype by Koji Matsuoka in the Renesas BSP,
>> and an earlier rework by Niklas Söderlund.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
>>
>> ---
...
>> +
>> +The digital output port nodes must contain at least one endpoint.
>> +
>> +Ports are optional if they are not connected to anything at the hardware level,
>> +but the driver may not provide any support for ports which are not described.
> 
> What the driver does is not relevant to the binding.

Of course. (Fixed)

> 
>> +
>> +Example:
>> +
>> +	video_receiver@70 {
> 
> video-receiver@70

Aha, I didn't realise the distinction between using '-' in node names and
properties vs '_' in labels.

Hopefully updated in my mind map. And I'll try to get this one right in the
future. :)

--
Regards

Kieran