linux-kernel - Re: [PATCH] x86: xen: remove unnecessary variable in xen_foreach_remap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <597538a2-4b50-273a-4fbf-2ccfff40c9d6@suse.com>
Date:   Mon, 26 Jun 2017 13:59:21 +0200
From:   Juergen Groß <jgross@...e.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Cc:     xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: xen: remove unnecessary variable in
 xen_foreach_remap_area()

On 06/24/2017 12:01 AM, Gustavo A. R. Silva wrote:
> Remove unnecessary variable mfn in function xen_foreach_remap_area() and,
> refactor the code.
> 
> Variable mfn at line 518:mfn = xen_remap_buf.mfns[i];
> is only being used to store a value to be passed as
> an argument to the xen_update_mem_tables() function.
> This value can be passed directly, which makes variable
> mfn unnecessary. Also, value assigned to variable mfn
> at line 534:mfn = xen_remap_mfn; is never used.
> 
> Addresses-Coverity-ID: 1260110
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Reviewed-by: Juergen Gross <jgross@...e.com>


Thanks,

Juergen