linux-kernel - [tip:irq/core] genirq: Set irq masked state when initializing irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Jun 2017 06:58:14 -0700
From:   tip-bot for Jeffy Chen <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     jeffy.chen@...k-chips.com, linux-kernel@...r.kernel.org,
        mingo@...nel.org, hpa@...or.com, tglx@...utronix.de
Subject: [tip:irq/core] genirq: Set irq masked state when initializing
 irq_desc

Commit-ID:  d829b8fb2431595422289cfc210f0a955a8bec74
Gitweb:     http://git.kernel.org/tip/d829b8fb2431595422289cfc210f0a955a8bec74
Author:     Jeffy Chen <jeffy.chen@...k-chips.com>
AuthorDate: Mon, 26 Jun 2017 19:33:33 +0800
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Mon, 26 Jun 2017 14:05:41 +0200

genirq: Set irq masked state when initializing irq_desc

The irq default state is set to disabled when allocating irq desc, but the
masked state flag is not set. This is inconsistent vs. the state tracking
logic which is used to prevent unnecessary calls to hardware level irq chip
functions.

Set the masked state flag as well.

Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: tfiga@...omium.org
Cc: briannorris@...omium.org
Cc: dianders@...omium.org
Link: http://lkml.kernel.org/r/1498476814-12563-1-git-send-email-jeffy.chen@rock-chips.com

---
 kernel/irq/irqdesc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 35a95fa..948b50e 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -116,6 +116,7 @@ static void desc_set_defaults(unsigned int irq, struct irq_desc *desc, int node,
 	desc->irq_data.chip_data = NULL;
 	irq_settings_clr_and_set(desc, ~0, _IRQ_DEFAULT_INIT_FLAGS);
 	irqd_set(&desc->irq_data, IRQD_IRQ_DISABLED);
+	irqd_set(&desc->irq_data, IRQD_IRQ_MASKED);
 	desc->handle_irq = handle_bad_irq;
 	desc->depth = 1;
 	desc->irq_count = 0;