linux-kernel - [tip:ras/core] RAS/CEC: Check the correct variable in the debugfs error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-32288daf3f2439f57167c03cd679c2eba28923b7@git.kernel.org>
Date:   Mon, 26 Jun 2017 07:04:28 -0700
From:   tip-bot for Christophe JAILLET <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     hpa@...or.com, bp@...e.de, linux-kernel@...r.kernel.org,
        christophe.jaillet@...adoo.fr, mingo@...nel.org, tglx@...utronix.de
Subject: [tip:ras/core] RAS/CEC: Check the correct variable in the debugfs
 error handling

Commit-ID:  32288daf3f2439f57167c03cd679c2eba28923b7
Gitweb:     http://git.kernel.org/tip/32288daf3f2439f57167c03cd679c2eba28923b7
Author:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
AuthorDate: Mon, 26 Jun 2017 14:35:32 +0200
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Mon, 26 Jun 2017 15:58:57 +0200

RAS/CEC: Check the correct variable in the debugfs error handling

Check the correct variable when handling a potential error from
debugfs_create_file(). Most likely a copy-paste botch.

[ Rewrite commit message. ]
Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Signed-off-by: Borislav Petkov <bp@...e.de>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Link: http://lkml.kernel.org/r/20170623062440.6726-1-christophe.jaillet@wanadoo.fr

---
 drivers/ras/cec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index 6aab46d..d0e5d6e 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -481,7 +481,7 @@ static int __init create_debugfs_nodes(void)
 
 	count = debugfs_create_file("count_threshold", S_IRUSR | S_IWUSR, d,
 				    &count_threshold, &count_threshold_ops);
-	if (!decay) {
+	if (!count) {
 		pr_warn("Error creating count_threshold debugfs node!\n");
 		goto err;
 	}