linux-kernel - Re: [PATCH] xfs: fix semicolon.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170626155442.GF4733@birch.djwong.org>
Date:   Mon, 26 Jun 2017 08:54:42 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     kbuild test robot <fengguang.wu@...el.com>
Cc:     Brian Foster <bfoster@...hat.com>, kbuild-all@...org,
        linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: fix semicolon.cocci warnings

On Mon, Jun 26, 2017 at 11:57:44PM +0800, kbuild test robot wrote:
> fs/xfs/xfs_log.c:2092:38-39: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Fixes: d4ca1d550d05 ("xfs: dump transaction usage details on log reservation overrun")
> CC: Brian Foster <bfoster@...hat.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

Looks good, will test...
Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

--D

> ---
> 
>  xfs_log.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -2089,7 +2089,7 @@ xlog_print_trans(
>  			xfs_warn(mp, "    type	= 0x%x", vec->i_type);
>  			xfs_warn(mp, "    len	= %d", vec->i_len);
>  			xfs_warn(mp, "    first %d bytes of iovec[%d]:", dumplen, i);
> -			xfs_hex_dump(vec->i_addr, dumplen);;
> +			xfs_hex_dump(vec->i_addr, dumplen);
>  
>  			vec++;
>  		}
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html