linux-kernel - Re: [PATCH linux 4/4] drivers/fsi/occ: Add in-kernel API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170626183545.lalthvn4xufa52ww@rob-hp-laptop>
Date:   Mon, 26 Jun 2017 13:35:45 -0500
From:   Rob Herring <robh@...nel.org>
To:     Eddie James <eajames@...ux.vnet.ibm.com>
Cc:     linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        devicetree@...r.kernel.org, mark.rutland@....com,
        bradleyb@...ziesquirrel.com, jk@...abs.org,
        cbostic@...ux.vnet.ibm.com, joel@....id.au, andrew@...id.au,
        "Edward A. James" <eajames@...ibm.com>
Subject: Re: [PATCH linux 4/4] drivers/fsi/occ: Add in-kernel API

On Wed, Jun 21, 2017 at 02:38:01PM -0500, Eddie James wrote:
> From: "Edward A. James" <eajames@...ibm.com>
> 
> Add an in-kernel read/write API with exported functions. This is
> necessary for other drivers which want to directly interact with the
> OCC. Also parse the OCC device tree node for child nodes and create
> child platform devices accordingly.
> 
> Signed-off-by: Edward A. James <eajames@...ibm.com>
> ---
>  .../devicetree/bindings/fsi/ibm,p9-occ.txt         |   8 ++
>  drivers/fsi/occ.c                                  | 140 +++++++++++++++++----
>  include/linux/occ.h                                |  27 ++++
>  3 files changed, 154 insertions(+), 21 deletions(-)
>  create mode 100644 include/linux/occ.h
> 
> diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt b/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
> index 88002b9..71afba3 100644
> --- a/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
> +++ b/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
> @@ -6,10 +6,18 @@ Required properties:
>  
>  Optional properties:
>   - reg = <processor index>;	: index for the processor this OCC device is on
> + - <child nodes>		: Drivers for devices which communicate with
> +				  this OCC. Child nodes have no required or
> +				  optional properties that the OCC driver will
> +				  use.

Please put all the binding in a single, separate patch.

>  
>  Examples:
>  
>      occ@1 {
>          compatible = "ibm,p9-occ";
>          reg = <1>;
> +
> +	occ-hwmon@1 {
> +		compatible = "ibm,p9-occ-hwmon";
> +	};

This looks like you are creating a node just to instantiate a driver as 
hwmon is a Linuxism. Just have the parent OCC driver instantiate a hwmon 
driver.

Rob