linux-kernel - Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2EF4805B-514F-48AD-95BB-170AF7B24D36@sigma-star.at>
Date:   Mon, 26 Jun 2017 07:40:58 +0200
From:   David Gstir <david@...ma-star.at>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Horia Geantă <horia.geanta@....com>,
        Dan Douglass <dan.douglass@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "richard@...ma-star.at" <richard@...ma-star.at>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt

Herbert,

> On 20 Jun 2017, at 03:28, Herbert Xu <herbert@...dor.apana.org.au> wrote:
> 
> On Mon, Jun 19, 2017 at 10:31:27AM +0000, Horia Geantă wrote:
>> 
>> IIUC, IV update is required only in case of CBC.
>> Since this callback is used also for CTR, we should avoid the copy:
>> if ((ctx->cdata.algtype & OP_ALG_AAI_MASK) == OP_ALG_AAI_CBC) ...
> 
> No it is needed for CTR too.

So, am I correct in assuming that it is required for all modes including AEAD modes like GCM?
In that case I'll include a fix for the CAAM GCM mode too.

Thanks,
David