linux-kernel - RE: [PATCH] Staging: visorbus: Fix coding style warning from checkpatch.pl.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY4PR07MB317673D4A04D8F98AB9DC8C1F0DC0@CY4PR07MB3176.namprd07.prod.outlook.com>
Date:   Tue, 27 Jun 2017 20:37:47 +0000
From:   "Kershner, David A" <David.Kershner@...sys.com>
To:     Quytelda Kahja <quytelda@...alin.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Sell, Timothy C" <Timothy.Sell@...sys.com>,
        "Binder, David Anthony" <David.Binder@...sys.com>
CC:     "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Staging: visorbus: Fix coding style warning from
 checkpatch.pl.

> -----Original Message-----
> From: Quytelda Kahja [mailto:quytelda@...alin.org]
> Sent: Monday, June 26, 2017 7:32 PM
> To: Kershner, David A <David.Kershner@...sys.com>;
> gregkh@...uxfoundation.org; Sell, Timothy C <Timothy.Sell@...sys.com>;
> Binder, David Anthony <David.Binder@...sys.com>
> Cc: devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org; Quytelda
> Kahja <quytelda@...alin.org>
> Subject: [PATCH] Staging: visorbus: Fix coding style warning from
> checkpatch.pl.
> 
> Replace the literal function name "create_bus_instance" with the format
> specifier "%s" so it can be dynamically filled by the __func__ macro.
> 
> Signed-off-by: Quytelda Kahja <quytelda@...alin.org>

I can't get this to apply to Greg's staging-next branch. It appears to be missing
at least patch: 

commit 9e78fd35d staging: unisys: visorbus: renamed functions like *_bus_instance 
			       to match driver namespace

Please update and send again. 

Thanks, 
David Kershner

> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
> b/drivers/staging/unisys/visorbus/visorbus_main.c
> index a692561c81c8..b6caa7a98692 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -1032,7 +1032,7 @@ create_bus_instance(struct visor_device *dev)
>  err_debugfs_dir:
>  	debugfs_remove_recursive(dev->debugfs_dir);
>  	kfree(hdr_info);
> -	dev_err(&dev->device, "create_bus_instance failed: %d\n", err);
> +	dev_err(&dev->device, "%s failed: %d\n", __func__, err);
>  	return err;
>  }
> 
> --
> 2.13.2