linux-kernel - Re: [PATCH 1/4] i2c: add helpers to ease DMA handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170627211610.53oeludkm3sooo64@ninjato>
Date:   Tue, 27 Jun 2017 23:16:10 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Linux I2C <linux-i2c@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] i2c: add helpers to ease DMA handling

Hi Geert,

> > +static inline int i2c_check_msg_for_dma(struct i2c_msg *msg, unsigned int threshold,
> > +                                       u8 **ptr_for_bounce_buf)
> 
> __must_check?

Yes, why not.

> Isn't this function a bit large to be inlined?

That can be argued, yes. But I am unsure to bloat the core if the
function is so rarely needed...

> > +static inline void i2c_release_bounce_buf(struct i2c_msg *msg, u8 *bounce_buf)
> 
> This one is smaller.

Yup, but of course, they should be put in the same place, whereever that may be.

Thanks,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)