linux-kernel - Re: [RESEND PATCH] MIPS: head: Reorder instructions missing a delay slot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Jun 2017 23:40:18 +0200
From:   Ralf Baechle <ralf@...ux-mips.org>
To:     Karl Beldan <karl.beldan@...il.com>
Cc:     linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
        Karl Beldan <karl.beldan+oss@...il.com>,
        stable@...r.kernel.org, Jonas Gorski <jogo@...nwrt.org>
Subject: Re: [RESEND PATCH] MIPS: head: Reorder instructions missing a delay
 slot

On Tue, Jun 27, 2017 at 07:22:16PM +0000, Karl Beldan wrote:

> In this sequence the 'move' is assumed in the delay slot of the 'beq',
> but head.S is in reorder mode and the former gets pushed one 'nop'
> farther by the assembler.
> 
> The corrected behavior made booting with an UHI supplied dtb erratic.

Excellent catch, patch applied!

Thanks Karl,

  Ralf