linux-kernel - Re: [PATCH] tracing/kprobes: allow to create probe with a module name starting with a digit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170628070523.ab19eeb9b9b0ac7e21e0705f@kernel.org>
Date:   Wed, 28 Jun 2017 07:05:23 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Sabrina Dubroca <sd@...asysnail.net>, linux-kernel@...r.kernel.org,
        Ingo Molnar <mingo@...hat.com>,
        Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: Re: [PATCH] tracing/kprobes: allow to create probe with a module
 name starting with a digit

On Tue, 27 Jun 2017 10:07:45 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue, 27 Jun 2017 17:38:30 +0900
> Masami Hiramatsu <mhiramat@...nel.org> wrote:
> 
> > On Thu, 22 Jun 2017 11:24:42 +0200
> > Sabrina Dubroca <sd@...asysnail.net> wrote:
> > 
> > > Always try to parse an address, since kstrtoul() will safely fail when
> > > given a symbol as input. If that fails (which will be the case for a
> > > symbol), try to parse a symbol instead.
> > > 
> > > This allows creating a probe such as:
> > > 
> > >     p:probe/vlan_gro_receive 8021q:vlan_gro_receive+0
> > > 
> > > Which is necessary for this command to work:
> > > 
> > >     perf probe -m 8021q -a vlan_gro_receive
> > >   
> > 
> > Ah, I forgot that case.
> > Nice catch!
> > 
> > Acked-by: Masami Hiramatsu <mhiramat@...nel.org>
> >
> 
> Thanks Masami,
> 
> I can take this. Should this go to stable?

Yes, it should go to stable. 

Thank you,

-- 
Masami Hiramatsu <mhiramat@...nel.org>