linux-kernel - Re: [PATCH v5 4/4] KVM: async_pf: Let host know whether the guest support delivery async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2017 06:49:28 +0800
From:   Wanpeng Li <kernellwp@...il.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kvm <kvm@...r.kernel.org>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Wanpeng Li <wanpeng.li@...mail.com>
Subject: Re: [PATCH v5 4/4] KVM: async_pf: Let host know whether the guest
 support delivery async_pf as #PF vmexit

2017-06-27 21:19 GMT+08:00 Paolo Bonzini <pbonzini@...hat.com>:
>
>
> On 27/06/2017 03:47, Wanpeng Li wrote:
>> -             wrmsrl(MSR_KVM_ASYNC_PF_EN, pa | KVM_ASYNC_PF_ENABLED);
>> +             pa |= KVM_ASYNC_PF_DELIVERY_AS_PF_VMEXIT | KVM_ASYNC_PF_ENABLED;
>> +             wrmsr_safe(MSR_KVM_ASYNC_PF_EN, pa & 0xffffffff, pa >> 32);
>>               __this_cpu_write(apf_reason.enabled, 1);
>
> Better:
>
>         pa |= KVM_ASYNC_PF_ENABLED;
>
>         /* Async page fault support for L1 hypervisor is optional.  */
>         if (wrmsr_safe(MSR_KVM_ASYNC_PF_EN,
>                        pa | KVM_ASYNC_PF_DELIVERY_AS_PF_VMEXIT) < 0)
>                 wrmsrl(MSR_KVM_ASYNC_PF_EN, pa);

Good point. :)

Regards,
Wanpeng Li