linux-kernel - Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170627090042.GA2408@katana>
Date:   Tue, 27 Jun 2017 11:00:42 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Brendan Higgins <brendanhiggins@...gle.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        gregkh@...uxfoundation.org, davem@...emloft.net,
        mchehab@...nel.org, Joel Stanley <joel@....id.au>,
        martin.petersen@...cle.com,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>
Subject: Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C


> > If SCL is stuck low, how do you want to send a STOP?
> >
> 
> Fair point. I should probably drop that in the future and just do a
> reset, and even then, doing a
> reset is probably just wishful thinking. If a slave is holding down
> SCL, we are pretty screwed.

Yes, you'd need to reset the client device. And that has to be done in
the client driver. I wonder if i2c_transfer and friends should return a
specific error value in that case... need to think about it.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)