linux-kernel - Re: [PATCH net-next] netfilter: conntrack: add a new NF_CT_EXT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 27 Jun 2017 18:06:39 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Lin Zhang <xiaolou4617@...il.com>
Cc:     kbuild-all@...org, pablo@...filter.org, kadlec@...ckhole.kfki.hu,
        fw@...len.de, davem@...emloft.net, linux-kernel@...r.kernel.org,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, Lin Zhang <xiaolou4617@...il.com>
Subject: Re: [PATCH net-next] netfilter: conntrack: add a new
 NF_CT_EXT_EXPAND extension

Hi Lin,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Lin-Zhang/netfilter-conntrack-add-a-new-NF_CT_EXT_EXPAND-extension/20170627-000844
config: i386-allyesconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In function 'total_extension_size',
       inlined from 'nf_conntrack_init_start' at net//netfilter/nf_conntrack_core.c:1893:25:
>> net//netfilter/nf_conntrack_core.c:1859:171: error: call to '__compiletime_assert_1859' declared with attribute error: BUILD_BUG_ON failed: NF_CT_EXT_NUM > 9
     BUILD_BUG_ON(NF_CT_EXT_NUM > 9);
                                                                                                                                                                              ^                          

vim +/__compiletime_assert_1859 +1859 net//netfilter/nf_conntrack_core.c

fae718dda Patrick McHardy        2007-12-24  1853  module_param_call(hashsize, nf_conntrack_set_hashsize, param_get_uint,
9fb9cbb10 Yasuyuki Kozakai       2005-11-09  1854  		  &nf_conntrack_htable_size, 0600);
9fb9cbb10 Yasuyuki Kozakai       2005-11-09  1855  
ab71632c4 Geert Uytterhoeven     2017-05-03  1856  static __always_inline unsigned int total_extension_size(void)
b3a5db109 Florian Westphal       2017-04-16  1857  {
b3a5db109 Florian Westphal       2017-04-16  1858  	/* remember to add new extensions below */
b3a5db109 Florian Westphal       2017-04-16 @1859  	BUILD_BUG_ON(NF_CT_EXT_NUM > 9);
b3a5db109 Florian Westphal       2017-04-16  1860  
b3a5db109 Florian Westphal       2017-04-16  1861  	return sizeof(struct nf_ct_ext) +
b3a5db109 Florian Westphal       2017-04-16  1862  	       sizeof(struct nf_conn_help)
b3a5db109 Florian Westphal       2017-04-16  1863  #if IS_ENABLED(CONFIG_NF_NAT)
b3a5db109 Florian Westphal       2017-04-16  1864  		+ sizeof(struct nf_conn_nat)
b3a5db109 Florian Westphal       2017-04-16  1865  #endif
b3a5db109 Florian Westphal       2017-04-16  1866  		+ sizeof(struct nf_conn_seqadj)
b3a5db109 Florian Westphal       2017-04-16  1867  		+ sizeof(struct nf_conn_acct)
b3a5db109 Florian Westphal       2017-04-16  1868  #ifdef CONFIG_NF_CONNTRACK_EVENTS
b3a5db109 Florian Westphal       2017-04-16  1869  		+ sizeof(struct nf_conntrack_ecache)
b3a5db109 Florian Westphal       2017-04-16  1870  #endif
b3a5db109 Florian Westphal       2017-04-16  1871  #ifdef CONFIG_NF_CONNTRACK_TIMESTAMP
b3a5db109 Florian Westphal       2017-04-16  1872  		+ sizeof(struct nf_conn_tstamp)
b3a5db109 Florian Westphal       2017-04-16  1873  #endif
b3a5db109 Florian Westphal       2017-04-16  1874  #ifdef CONFIG_NF_CONNTRACK_TIMEOUT
b3a5db109 Florian Westphal       2017-04-16  1875  		+ sizeof(struct nf_conn_timeout)
b3a5db109 Florian Westphal       2017-04-16  1876  #endif
b3a5db109 Florian Westphal       2017-04-16  1877  #ifdef CONFIG_NF_CONNTRACK_LABELS
b3a5db109 Florian Westphal       2017-04-16  1878  		+ sizeof(struct nf_conn_labels)
b3a5db109 Florian Westphal       2017-04-16  1879  #endif
b3a5db109 Florian Westphal       2017-04-16  1880  #if IS_ENABLED(CONFIG_NETFILTER_SYNPROXY)
b3a5db109 Florian Westphal       2017-04-16  1881  		+ sizeof(struct nf_conn_synproxy)
b3a5db109 Florian Westphal       2017-04-16  1882  #endif
b3a5db109 Florian Westphal       2017-04-16  1883  	;
b3a5db109 Florian Westphal       2017-04-16  1884  };
b3a5db109 Florian Westphal       2017-04-16  1885  
f94161c1b Gao feng               2013-01-21  1886  int nf_conntrack_init_start(void)
9fb9cbb10 Yasuyuki Kozakai       2005-11-09  1887  {
f205c5e0c Patrick McHardy        2007-07-07  1888  	int max_factor = 8;
0c5366b3a Florian Westphal       2016-05-09  1889  	int ret = -ENOMEM;
cc41c84b7 Florian Westphal       2017-04-14  1890  	int i;
93bb0ceb7 Jesper Dangaard Brouer 2014-03-03  1891  
b3a5db109 Florian Westphal       2017-04-16  1892  	/* struct nf_ct_ext uses u8 to store offsets/size */
b3a5db109 Florian Westphal       2017-04-16 @1893  	BUILD_BUG_ON(total_extension_size() > 255u);
b3a5db109 Florian Westphal       2017-04-16  1894  
a3efd8120 Florian Westphal       2016-04-18  1895  	seqcount_init(&nf_conntrack_generation);
a3efd8120 Florian Westphal       2016-04-18  1896  

:::::: The code at line 1859 was first introduced by commit
:::::: b3a5db109e0670d6d168e9cd9de4d272a68f7c35 netfilter: conntrack: use u8 for extension sizes again

:::::: TO: Florian Westphal <fw@...len.de>
:::::: CC: Pablo Neira Ayuso <pablo@...filter.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (59470 bytes)