linux-kernel - [PATCH V3] lightnvm: if LUNs are already allocated fix return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170627115531.GA53387@dhcp-216.srv.tuxera.com>
Date:   Tue, 27 Jun 2017 14:55:33 +0300
From:   Rakesh Pandit <rakesh@...era.com>
To:     Jens Axboe <axboe@...com>,
        Matias Bjørling <m@...rling.me>
CC:     <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Matias Bjørling <matias@...xlabs.com>,
        Frans Klaver <fransklaver@...il.com>,
        Javier González <jg@...htnvm.io>
Subject: [PATCH V3] lightnvm: if LUNs are already allocated fix return

While creating new device with NVM_DEV_CREATE if LUNs are already
allocated ioctl would return -ENOMEM which is wrong.  This patch
propagates -EBUSY from nvm_reserve_luns which is correct response.

Fixes: ade69e243 ("lightnvm: merge gennvm with core")
Signed-off-by: Rakesh Pandit <rakesh@...era.com>
---

V3: Propagate return value from nvm_reserve_luns instead of hard-coding (Frans)
V2: return error code directly instead of using ret variable (Frans)

 drivers/lightnvm/core.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index b8f82f5..ddae430 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -252,8 +252,9 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create)
 	}
 	mutex_unlock(&dev->mlock);
 
-	if (nvm_reserve_luns(dev, s->lun_begin, s->lun_end))
-		return -ENOMEM;
+	ret = nvm_reserve_luns(dev, s->lun_begin, s->lun_end);
+	if (ret)
+		return ret;
 
 	t = kmalloc(sizeof(struct nvm_target), GFP_KERNEL);
 	if (!t) {
-- 
2.5.5