linux-kernel - Re: [PATCH v2 2/3] cros_ec: Fix deadlock when EC is not responsive at probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170627153612.GB39605@decatoncale.mtv.corp.google.com>
Date:   Tue, 27 Jun 2017 08:36:12 -0700
From:   Benson Leung <bleung@...gle.com>
To:     Thierry Escande <thierry.escande@...labora.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Benson Leung <bleung@...omium.org>,
        linux-kernel@...r.kernel.org, enric.balletbo@...labora.com
Subject: Re: [PATCH v2 2/3] cros_ec: Fix deadlock when EC is not responsive
 at probe

Hi Thierry,

On Tue, Feb 14, 2017 at 08:58:01PM +0100, Thierry Escande wrote:
> From: Gwendal Grignou <gwendal@...omium.org>
> 
> When the EC is not responsive at probe, we try to get basic information
> (protocol to use) later on through cros_xfer_cmd() call.
> This patch makes sure there is no deadlock when re-probing the EC by
> replacing call to cros_xfer_cmd() with send_command() in the function
> cros_ec_get_host_command_version_mask(). Also, this patch adds the
> function header indicating it must be called protected.
> 
> Signed-off-by: Gwendal Grignou <gwendal@...omium.org>
> Signed-off-by: Thierry Escande <thierry.escande@...labora.com>

Applied. Thanks again!

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)