linux-kernel - Re: [PATCH] platform/chrome: cros_ec_lightbar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170627162914.GD39605@decatoncale.mtv.corp.google.com>
Date:   Tue, 27 Jun 2017 09:29:14 -0700
From:   Benson Leung <bleung@...gle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Olof Johansson <olof@...om.net>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Lee Jones <lee.jones@...aro.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Benson Leung <bleung@...omium.org>,
        Eric Caruso <ejcaruso@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        Vincent Palatin <vpalatin@...omium.org>,
        Jeffery Yu <jefferyy@...dia.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_ec_lightbar - hide unused PM
 functions

Hi Arnd,

On Tue, Jun 27, 2017 at 05:36:36PM +0200, Arnd Bergmann wrote:
> The only reference to the new functions is inside of an #ifdef,
> which now causes a harmless warning when CONFIG_PM_SLEEP is not set:
> 
> chrome/cros_ec_dev.c:478:12: error: 'ec_device_resume' defined but not used [-Werror=unused-function]
> chrome/cros_ec_dev.c:469:12: error: 'ec_device_suspend' defined but not used [-Werror=unused-function]
> 
> This marks the two functions as __maybe_unused so they can get
> silently dropped by the compiler.
> 
> Fixes: 405c84308c43 ("platform/chrome: cros_ec_lightbar - Control of suspend/resume lightbar sequence")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Good catch. Applied. Thanks!
-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)