linux-kernel - RE: [PATCH] staging: unisys: visorbus: constify channel_attr_grp and dev_attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY4PR07MB3176E297EECF8F66C48C25F9F0DC0@CY4PR07MB3176.namprd07.prod.outlook.com>
Date:   Tue, 27 Jun 2017 17:02:53 +0000
From:   "Kershner, David A" <David.Kershner@...sys.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Thompson, Bryan E." <bryan.thompson@...sys.com>,
        "Wadgaonkar, Sameer Laxmikant" <Sameer.Wadgaonkar@...sys.com>,
        "jon.frisch@...sys.com" <jon.frisch@...sys.com>
CC:     *S-Par-Maintainer <SParMaintainer@...sys.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] staging: unisys: visorbus: constify channel_attr_grp and
 dev_attr_grp

> -----Original Message-----
> From: Arvind Yadav [mailto:arvind.yadav.cs@...il.com]
> Sent: Friday, June 23, 2017 3:37 AM
> To: Kershner, David A <David.Kershner@...sys.com>;
> gregkh@...uxfoundation.org; Thompson, Bryan E.
> <bryan.thompson@...sys.com>; Wadgaonkar, Sameer Laxmikant
> <Sameer.Wadgaonkar@...sys.com>; jon.frisch@...sys.com
> Cc: *S-Par-Maintainer <SParMaintainer@...sys.com>;
> devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] staging: unisys: visorbus: constify channel_attr_grp and
> dev_attr_grp
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    6712	    960	    521	   8193	   2001
> 	drivers/staging/unisys/visorbus/visorbus_main.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    6840	    832	    521	   8193	   2001
> 	drivers/staging/unisys/visorbus/visorbus_main.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
Acked-by: David Kershner <david.kershner@...sys.com>

> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
> b/drivers/staging/unisys/visorbus/visorbus_main.c
> index a692561..26f9885 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -249,7 +249,7 @@ static ssize_t typename_show(struct device *dev,
> struct device_attribute *attr,
>  		NULL
>  };
> 
> -static struct attribute_group channel_attr_grp = {
> +static const struct attribute_group channel_attr_grp = {
>  		.name = "channel",
>  		.attrs = channel_attrs,
>  };
> @@ -340,7 +340,7 @@ static ssize_t channel_id_show(struct device *dev,
>  		NULL
>  };
> 
> -static struct attribute_group dev_attr_grp = {
> +static const struct attribute_group dev_attr_grp = {
>  		.attrs = dev_attrs,
>  };
> 
> --
> 1.9.1