linux-kernel - Re: [RESEND PATCH v4 1/3] Bluetooth: bnep: fix possible might sleep error in bnep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0815411E-62D7-42DC-A0BF-78FD150C0949@holtmann.org>
Date:   Tue, 27 Jun 2017 19:32:52 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "open list:BLUETOOTH DRIVERS" <linux-bluetooth@...r.kernel.org>,
        rvaswani@...dia.com, Brian Norris <briannorris@...omium.org>,
        dmitry.torokhov@...il.com,
        Douglas Anderson <dianders@...omium.org>, acho@...e.com,
        Johan Hedberg <johan.hedberg@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "Gustavo F. Padovan" <gustavo@...ovan.org>
Subject: Re: [RESEND PATCH v4 1/3] Bluetooth: bnep: fix possible might sleep
 error in bnep_session

Hi Jeffy,

> It looks like bnep_session has same pattern as the issue reported in
> old rfcomm:
> 
> 	while (1) {
> 		set_current_state(TASK_INTERRUPTIBLE);
> 		if (condition)
> 			break;
> 		// may call might_sleep here
> 		schedule();
> 	}
> 	__set_current_state(TASK_RUNNING);
> 
> Which fixed at:
> 	dfb2fae Bluetooth: Fix nested sleeps
> 
> So let's fix it at the same way, also follow the suggestion of:
> https://lwn.net/Articles/628628/
> 
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
> Reviewed-by: Brian Norris <briannorris@...omium.org>
> Reviewed-by: AL Yu-Chen Cho <acho@...e.com>
> ---
> 
> Changes in v4: None
> Changes in v2: None
> 
> net/bluetooth/bnep/core.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)

all 3 patches have been applied to bluetooth-next tree.

Regards

Marcel