linux-kernel - Re: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2017 01:44:17 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Tommy Nguyen <remyabel@...il.com>
Cc:     kbuild-all@...org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Riley Andrews <riandrews@...roid.com>,
        linux-kernel@...r.kernel.org, Tommy Nguyen <remyabel@...il.com>
Subject: Re: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE

Hi Tommy,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.12-rc7 next-20170627]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Tommy-Nguyen/staging-android-ion-Use-DEFINE_DEBUGFS_ATTRIBUTE/20170626-055654
config: x86_64-randconfig-s3-06280039 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/staging/android/ion/ion.c: In function 'ion_device_add_heap':
>> drivers/staging/android/ion/ion.c:572:16: error: implicit declaration of function 'debugfs_create_file_unsafe' [-Werror=implicit-function-declaration]
      debug_file = debugfs_create_file_unsafe(
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/android/ion/ion.c:572:14: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      debug_file = debugfs_create_file_unsafe(
                 ^
   cc1: some warnings being treated as errors

vim +/debugfs_create_file_unsafe +572 drivers/staging/android/ion/ion.c

   566		plist_add(&heap->node, &dev->heaps);
   567	
   568		if (heap->shrinker.count_objects && heap->shrinker.scan_objects) {
   569			char debug_name[64];
   570	
   571			snprintf(debug_name, 64, "%s_shrink", heap->name);
 > 572			debug_file = debugfs_create_file_unsafe(
   573				debug_name, 0644, dev->debug_root, heap,
   574				&debug_shrink_fops);
   575			if (!debug_file) {

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28062 bytes)