[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170628225442.GP6973@jhogan-linux.le.imgtec.org>
Date: Wed, 28 Jun 2017 23:54:42 +0100
From: James Hogan <james.hogan@...tec.com>
To: Palmer Dabbelt <palmer@...belt.com>
CC: <peterz@...radead.org>, <mingo@...hat.com>, <mcgrof@...nel.org>,
<viro@...iv.linux.org.uk>, <sfr@...b.auug.org.au>,
<nicolas.dichtel@...nd.com>, <rmk+kernel@...linux.org.uk>,
<msalter@...hat.com>, <tklauser@...tanz.ch>, <will.deacon@....com>,
<paul.gortmaker@...driver.com>, <linux@...ck-us.net>,
<linux-kernel@...r.kernel.org>, <linux-arch@...r.kernel.org>,
<albert@...ive.com>
Subject: Re: [PATCH 9/9] RISC-V: Build Infastructure
On Wed, Jun 28, 2017 at 11:55:38AM -0700, Palmer Dabbelt wrote:
> diff --git a/arch/riscv/kernel/Makefile b/arch/riscv/kernel/Makefile
> new file mode 100644
> index 000000000000..7f58cd251ab8
> --- /dev/null
> +++ b/arch/riscv/kernel/Makefile
> @@ -0,0 +1,16 @@
> +#
> +# Makefile for the RISC-V Linux kernel
> +#
> +
> +extra-y := head.o vmlinux.lds
> +
> +obj-y := cpu.o entry.o irq.o process.o ptrace.o reset.o setup.o \
> + signal.o syscall_table.o sys_riscv.o time.o traps.o \
> + riscv_ksyms.o stacktrace.o vdso.o cacheinfo.o vdso/
I would suggest splitting these sort of things onto separate lines.
It'll make later changes much more readable (especially when you're
escaping newlines) as well as avoiding conflicts.
> +
> +CFLAGS_setup.o := -mcmodel=medany
> +
> +obj-$(CONFIG_SMP) += smpboot.o smp.o
same here
> +obj-$(CONFIG_MODULES) += module.o
> +
> +clean:
> diff --git a/arch/riscv/lib/Makefile b/arch/riscv/lib/Makefile
> new file mode 100644
> index 000000000000..120c38e77a46
> --- /dev/null
> +++ b/arch/riscv/lib/Makefile
> @@ -0,0 +1,5 @@
> +lib-y := delay.o memcpy.o memset.o uaccess.o
and here
> +
> +ifeq ($(CONFIG_64BIT),)
> +lib-y += udivdi3.o
> +endif
Would this work?
lib-$(CONFIG_32BIT) += udivdi3.o
> diff --git a/arch/riscv/mm/Makefile b/arch/riscv/mm/Makefile
> new file mode 100644
> index 000000000000..36ebe6feb5d6
> --- /dev/null
> +++ b/arch/riscv/mm/Makefile
> @@ -0,0 +1 @@
> +obj-y := init.o fault.o extable.o ioremap.o
and here
Cheers
James
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists