[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170628233254.GR6973@jhogan-linux.le.imgtec.org>
Date: Thu, 29 Jun 2017 00:32:55 +0100
From: James Hogan <james.hogan@...tec.com>
To: Palmer Dabbelt <palmer@...belt.com>
CC: <peterz@...radead.org>, <mingo@...hat.com>, <mcgrof@...nel.org>,
<viro@...iv.linux.org.uk>, <sfr@...b.auug.org.au>,
<nicolas.dichtel@...nd.com>, <rmk+kernel@...linux.org.uk>,
<msalter@...hat.com>, <tklauser@...tanz.ch>, <will.deacon@....com>,
<paul.gortmaker@...driver.com>, <linux@...ck-us.net>,
<linux-kernel@...r.kernel.org>, <linux-arch@...r.kernel.org>,
<albert@...ive.com>
Subject: Re: [PATCH 5/9] RISC-V: Task implementation
On Wed, Jun 28, 2017 at 11:55:34AM -0700, Palmer Dabbelt wrote:
> diff --git a/arch/riscv/include/asm/kprobes.h b/arch/riscv/include/asm/kprobes.h
> new file mode 100644
> index 000000000000..1190de7a0f74
> --- /dev/null
> +++ b/arch/riscv/include/asm/kprobes.h
> @@ -0,0 +1,22 @@
...
> +#ifdef CONFIG_KPROBES
> +#error "RISC-V doesn't skpport CONFIG_KPROBES"
> +#endif
I'm wondering where your fallback definition of e.g. NOKPROBE_SYMBOL
comes from then.
Could you just use the asm-generic one?
> diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c
> new file mode 100644
> index 000000000000..b13d3ea3bf79
> --- /dev/null
> +++ b/arch/riscv/kernel/process.c
> @@ -0,0 +1,131 @@
...
> +void show_regs(struct pt_regs *regs)
> +{
> + show_regs_print_info(KERN_DEFAULT);
> +
> + printk(KERN_CONT "sepc: " REG_FMT " ra : " REG_FMT " sp : " REG_FMT "\n",
> + regs->sepc, regs->ra, regs->sp);
I've noticed inconsistent use of pr_* and printk(KERN_* in this
patchset. Maybe now would be the best time to switch everything to pr_*.
> + /* Reset FPU context
> + * frm: round to nearest, ties to even (IEEE default)
> + * fflags: accrued exceptions cleared
> + */
Similarly lots of multiline comments which don't follow the standard
style in Documentation/process/coding-style.rst. Maybe now is the best
time to convert if you're going to.
Cheers
James
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists