linux-kernel - Re: [PATCH 1/1] xen/blkfront: always allocate grants first from per-queue persistent grants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170628083459.aodudybeq2zcvcsg@dhcp-3-128.uk.xensource.com>
Date:   Wed, 28 Jun 2017 09:34:59 +0100
From:   Roger Pau Monné <roger.pau@...rix.com>
To:     Dongli Zhang <dongli.zhang@...cle.com>
CC:     <xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>,
        <konrad.wilk@...cle.com>, <boris.ostrovsky@...cle.com>,
        <jgross@...e.com>
Subject: Re: [PATCH 1/1] xen/blkfront: always allocate grants first from
 per-queue persistent grants

On Wed, Jun 28, 2017 at 12:43:03PM +0800, Dongli Zhang wrote:
> This patch partially reverts 3df0e50 ("xen/blkfront: pseudo support for
> multi hardware queues/rings"). The xen-blkfront queue/ring might hang due
> to grants allocation failure in the situation when gnttab_free_head is
> almost empty while many persistent grants are reserved for this queue/ring.
> 
> As persistent grants management was per-queue since 73716df ("xen/blkfront:
> make persistent grants pool per-queue"), we should always allocate from
> persistent grants first.
> 
> Signed-off-by: Dongli Zhang <dongli.zhang@...cle.com>
> ---
>  drivers/block/xen-blkfront.c | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 3945963..d2b759f 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -713,6 +713,7 @@ static int blkif_queue_rw_req(struct request *req, struct blkfront_ring_info *ri
>  	 * existing persistent grants, or if we have to get new grants,
>  	 * as there are not sufficiently many free.
>  	 */
> +	bool new_persistent_gnts = false;
>  	struct scatterlist *sg;
>  	int num_sg, max_grefs, num_grant;
>  
> @@ -724,12 +725,13 @@ static int blkif_queue_rw_req(struct request *req, struct blkfront_ring_info *ri
>  		 */
>  		max_grefs += INDIRECT_GREFS(max_grefs);
>  
> -	/*
> -	 * We have to reserve 'max_grefs' grants because persistent
> -	 * grants are shared by all rings.
> -	 */
> -	if (max_grefs > 0)
> -		if (gnttab_alloc_grant_references(max_grefs, &setup.gref_head) < 0) {
> +	/* Check if we have enough persistent grants to allocate a requests */
> +	if (rinfo->persistent_gnts_c < max_grefs) {
> +		new_persistent_gnts = true;
> +
> +		if (gnttab_alloc_grant_references(
> +		    max_grefs - rinfo->persistent_gnts_c,
> +		    &setup.gref_head) < 0) {
>  			gnttab_request_free_callback(
>  				&rinfo->callback,
>  				blkif_restart_queue_callback,

AFAICT you should also change the call to gnttab_request_free_callback
to request for max_grefs - rinfo->persistent_gnts_c. In any case the
number of persistent grants is not going to decrease now, because the
buffer is per-queue, so the only thing that can happen is that
requests complete and the number of persistent grants increase.

Roger.